Update roslyn to 5.12.0-1.26459.1 - #9743
Closed
dibarbet wants to merge 2 commits into
Closed
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new changelog sub-bullet appears to describe an ambiguous internal refactor and should be omitted or rewritten to reflect a clearly user-visible impact per the repo’s Roslyn-update changelog guidance.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Lite
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
CHANGELOG.md — The nested entry “Centralize Language Server workspace folder tracking” reads like an internal… |
What changed in this PR
Updates the default Roslyn component version used by the VS Code C# extension and records the bump in the repository changelog.
Changes:
- Bump the default Roslyn version to
5.12.0-1.26459.1. - Add a corresponding
CHANGELOG.mdentry for the Roslyn update.
| File | Description |
|---|---|
| package.json | Updates the default Roslyn component version string. |
| CHANGELOG.md | Adds a new 2.152.x changelog entry for the Roslyn version bump. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+8
to
+9
| * Update Roslyn to 5.12.0-1.26459.1 (PR: [#9743](https://github.com/dotnet/vscode-csharp/pull/9743)) | ||
| * Centralize Language Server workspace folder tracking (PR: [#85105](https://github.com/dotnet/roslyn/pull/85105)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roslyn build: dotnet-roslyn-official build 3070675
View Complete Diff of Changes
Option Strict On) (PR: #85124)(PR: #83)